This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ warnings vs. errors


Jonathan Wakely wrote:
2008/6/18 Mark Mitchell:
* I don't think the pedwarn in joust() in cp/call.c should be a
permerror, is this a GNU extension?
         if (warn)
           {
             pedwarn ("\
ISO C++ says that these are ambiguous, even \
though the worst conversion for the first is better than \
the worst conversion for the second:");
             print_z_candidate (_("candidate 1:"), w);
             print_z_candidate (_("candidate 2:"), l);
           }
Yes, that is a historical GNU extension.  I think this should just be a
warning, given that the whole section of code is guarded with !pedantic.

OK. Should I also get rid of the escaped newlines and rely on string concatenation for the text?

It's fine if you want to do that, but I don't think it's important either way.


Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]