This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [tuples] Avoid copying in gimplifier

From: Jan Hubicka <jh at suse dot cz>
To: Jan Hubicka <hubicka at ucw dot cz>
Cc: Diego Novillo <dnovillo at google dot com>, Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
Date: Wed, 18 Jun 2008 16:47:01 +0200
Subject: Re: [tuples] Avoid copying in gimplifier
References: <20080618122111.GN7888@kam.mff.cuni.cz> <48591764.306@google.com> <20080618141644.GJ13387@atrey.karlin.mff.cuni.cz>

Hi,
this seems to fix it.  x86_64 va-arg expander use OVF expression
in multiple statements built.  This naturaly breaks when we don't copy
everything.

I am bootstrapping now and will commit it as obvious if it passes.

Honza

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c	(revision 136895)
+++ config/i386/i386.c	(working copy)
@@ -5661,7 +5661,7 @@
 
   t = build2 (POINTER_PLUS_EXPR, TREE_TYPE (t), t,
 	      size_int (rsize * UNITS_PER_WORD));
-  t = build2 (GIMPLE_MODIFY_STMT, TREE_TYPE (ovf), ovf, t);
+  t = build2 (GIMPLE_MODIFY_STMT, TREE_TYPE (ovf), unshare_expr (ovf), t);
   gimplify_and_add (t, pre_p);
 
   if (container)

Follow-Ups:
- Re: [tuples] Avoid copying in gimplifier
  - From: Diego Novillo

References:
- [tuples] Avoid copying in gimplifier
  - From: Jan Hubicka
- Re: [tuples] Avoid copying in gimplifier
  - From: Diego Novillo
- Re: [tuples] Avoid copying in gimplifier
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]