Re: [PATCH] Fix omp_lib.f90 with -fimplicit-none (PR libgomp/36471)

[Jakub Jelinek <jakub at redhat dot com>]

On Wed, Jun 11, 2008 at 09:37:55AM +0200, Tobias Burnus wrote:
> Jakub Jelinek wrote:
> >These pastos cause -fimplicit-none failures with omp_lib.f90.
> 
> Thanks. Shouldn't one apply also such a patch to make sure it won't 
> happen again?

I have no problems with the omp_lib.f90.in change, but what would the
configure.ac change buy us over it?  If it affects also the libgomp
testsuite, then it will surely break a lot of tests, if not, omp_lib.f90
is the only module compiled during libgomp build and there are no plans to
add more Fortran code to libgomp.

> Index: libgomp/configure.ac
> ===================================================================
> --- libgomp/configure.ac        (Revision 136654)
> +++ libgomp/configure.ac        (Arbeitskopie)
> @@ -144,7 +144,7 @@ AM_MAINTAINER_MODE
>  #AC_PROG_FC(gfortran)
>  FC="$GFORTRAN"
>  AC_PROG_FC(gfortran)
> -FCFLAGS="$FCFLAGS -Wall"
> +FCFLAGS="$FCFLAGS -Wall -Werror -fimplicit-none"
> 
>  # For libtool versioning info, format is CURRENT:REVISION:AGE
>  libtool_VERSION=1:0:0
> Index: libgomp/omp_lib.f90.in
> ===================================================================
> --- libgomp/omp_lib.f90.in      (Revision 136654)
> +++ libgomp/omp_lib.f90.in      (Arbeitskopie)
> @@ -26,6 +26,7 @@
>  !  General Public License.
> 
>        module omp_lib_kinds
> +        implicit none
>          integer, parameter :: omp_integer_kind = 4
>          integer, parameter :: omp_logical_kind = 4
>          integer, parameter :: omp_lock_kind = @OMP_LOCK_KIND@
> @@ -35,6 +36,7 @@
> 
>        module omp_lib
>          use omp_lib_kinds
> +        implicit none
>          integer, parameter :: openmp_version = 200805
>          integer (omp_sched_kind), parameter :: omp_sched_static = 1
>          integer (omp_sched_kind), parameter :: omp_sched_dynamic = 2

	Jakub