This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, committed] Fix config.gcc shell lossage

From: Ian Lance Taylor <iant at google dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: Michael Meissner <michael dot meissner at amd dot com>, gcc-patches at gcc dot gnu dot org, christophe dot harle at amd dot com
Date: Tue, 10 Jun 2008 11:18:17 -0700
Subject: Re: [PATCH, committed] Fix config.gcc shell lossage
References: <20080609162203.GA11510@mmeissner-gold.amd.com> <m3tzg1i5kg.fsf@google.com> <jeiqwhw6b1.fsf@sykes.suse.de>

Andreas Schwab <schwab@suse.de> writes:

> Ian Lance Taylor <iant@google.com> writes:
>
>> Michael Meissner <michael.meissner@amd.com> writes:
>>
>>> -	if test $enable_cld = yes; then
>>> +	if test "x$enable_cld" = xyes; then
>>
>> I'll just note that you don't need to use both a prefix and
>> doublequotes.  Either one alone suffices.
>
> Unless $enable_cld can contain whitespace, which it can.

Fair enough, but you still don't need the prefix.

Ian

Follow-Ups:
- Re: [PATCH, committed] Fix config.gcc shell lossage
  - From: Michael Meissner

References:
- [PATCH, committed] Fix config.gcc shell lossage
  - From: Michael Meissner
- Re: [PATCH, committed] Fix config.gcc shell lossage
  - From: Ian Lance Taylor
- Re: [PATCH, committed] Fix config.gcc shell lossage
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]