This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove deprecated targets
On Saturday 07 June 2008 03:55:46 pm Joseph S. Myers wrote:
> > I'll improve the error message.
http://autogen.sourceforge.net/data/autogen-5.9.6pre1.tar.gz will now give
the line number of the original here string marker, instead of the end of file. :)
> AAB_sun_memcpy looks like another fix that could be removed, as
> Sun OS 4.x support was obsoleted in GCC 3.3. There are quite a lot of
> fixes whose descriptions suggest they are only relevant on systems no
> longer supported, plus a few apparently only relevant to systems such as
> VxWorks where fixincludes is disabled in mkfixinc.sh.
Ten years is a long time to remember details. :) Anyway, way back when I
wanted to provide a mechanism for determining when various fixes were
no longer in use. Specifically, record the list of fixes that apply to each file
and emit that list when "altered_ct" would be incremented inside of the
test_for_changes function. If we could get the emitted list for every supported
platform, then we'd know which fixes were being applied to files that were
being altered. I was told way back when that that was not feasible.
> I only looked for
> and removed those for the systems I was removing support for now, not
> those for systems for which support was removed long ago. And what's the
> idea of all the fixes in inclhack.def under conditionals such as #ifdef
> SVR4? As far as I can see none of them actually get through to fixincl.x,
> so there doesn't seem much point in keeping them around.
They are "commentary", unless you invoke autogen with "-DSVR4 -DSVR5" on
the command line. I've now removed them. I fuzzily remember seeing them
in the original scripts (though I might be misremembering), noticing that they
were not really useful, so I kept them as comments until I was sure they were
not needed. I guess that after 10 years I can surmise that they are not needed.
That helps remove clutter from inclhack.def, but doesn't do much for removing
cruft from the generated source.
Cheers - Bruce