This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix MIPS NewABI fallout from recent tree-nested.c fix
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org, rdsandiford at googlemail dot com, "Eric Botcazou" <ebotcazou at adacore dot com>
- Date: Tue, 3 Jun 2008 10:53:35 +0200
- Subject: Re: Fix MIPS NewABI fallout from recent tree-nested.c fix
- References: <871w3fsfj6.fsf@firetop.home>
On Mon, Jun 2, 2008 at 11:17 PM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> Eric's recent tree-nested.c patch allows us to inline gcc.dg/nest.c:foo
> into main. This creates a function in which the only use of the $gp
> register is an implicit one in FUNCTION_PROFILER, and a bug in the
> MIPS port meant that we'd delete the initialisation as dead.
>
> Fixed by extending the !TARGET_EXPLICIT_RELOCS case to include
> crtl->profile as well, and making sure that it is used even
> for LOADGP_ABSOLUTE (for which !TARGET_EXPLICIT_RELOCS is known
> to be false).
>
> Tested on mips64el-linux-gnu and applied.
Erics patch also went on the 4.3 branch. If you are comfortable with
your change can you also put it there to not regress on the branch?
Thanks,
Richard.