This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/7]: Ping3: Merge from Stack Branch - i386 backend changes


On Wed, May 28, 2008 at 8:11 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, May 28, 2008 at 04:48:11PM +0200, Jan Hubicka wrote:
>> > Jan,
>> >
>> > Here is most recent i386 backend patch after Richard's review. Can you
>> > review it when you have time?
>>
>>
>>  #define CAN_ELIMINATE(FROM, TO) \
>> -  ((TO) == STACK_POINTER_REGNUM ? !frame_pointer_needed : 1)
>> +  (stack_realign_fp \
>> +  ? ((FROM) == ARG_POINTER_REGNUM && (TO) == HARD_FRAME_POINTER_REGNUM) \
>> +    || ((FROM) == FRAME_POINTER_REGNUM && (TO) == STACK_POINTER_REGNUM) \
>> +  : ((TO) == STACK_POINTER_REGNUM ? !frame_pointer_needed : 1))
>>
>> I would preffer to have this offline with some comments on what cases
>> are handling.  The condition is quite hard to parse.
>
> I will make the change.
>

I am checking this patch into stack branch.

Thanks.

H.J.
----
2008-05-28  H.J. Lu  <hongjiu.lu@intel.com>

        * config/i386/i386.c (ix86_can_elimination): New.
        * config/i386/i386-protos.h (ix86_can_eliminate): Likewise.
        * config/i386/i386.h (CAN_ELIMINATE): Use it.

Attachment: e.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]