This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [trunk][patch] fix another invalid sharing in see


2008/5/23 Ian Lance Taylor <iant@google.com>:
> I need to see more details.  This doesn't look right.  ref_copy was
> set like this:
>  rtx ref_copy = see_copy_insn (ref);
> So it is already a copy.  Why do we need to copy it again?
>
> It was changed here:
>  ref_copy = replace_rtx (ref_copy, dest_reg, copy_rtx (subreg));
>
> Is the problem in this case that the copied subreg is being inserted
> into the insn in two different places?

This was fixed by the previous fix for the bug found by using
enable-checking=rtl. I am dropping the patch.

> Thanks.
>
> Ian
>

Thanks,
-- 
Rafael Avila de Espindola

Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland

Registered in Dublin, Ireland
Registration Number: 368047


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]