This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch i386]: PR/36280 option -fno-leading-underscore not treated

From: "Kai Tietz" <ktietz70 at googlemail dot com>
To: "Danny Smith" <dansmister at gmail dot com>
Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 21 May 2008 21:37:37 +0200
Subject: Re: [patch i386]: PR/36280 option -fno-leading-underscore not treated
References: <90baa01f0805211018n1c6d8482j75f6545e1c337d1@mail.gmail.com> <9c03c2dd0805211222y7f885fdfpe792385d84bf4daa@mail.gmail.com>

2008/5/21 Danny Smith <dansmister@gmail.com>:
> On Thu, May 22, 2008 at 5:18 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>> Hi,
>>
>> In cygming.h the macro ASM_OUTPUT_LABELREF uses directly
>> USER_LABEL_PREFIX without regarding the option
>> flag_leading_underscore. Shouldn't be used  user_label_prefix in this
>> macro? (see PR/36280). I prepared a patch for this.
>>
>> ChangeLog
>>
>> 2008-05-21  Kai Tietz  <kai.tietz@onevision.com>
>>
>>        PR/36280
>>
>>        * config/i386/cygming.h (ASM_OUTPUT_LABELREF): Treat
>>        option -f(no-)leading-underscore.
>>
>> Is this patch ok for apply?
>
> This is OK.  I think the ChangeLog text should be "Honor  option ..."
> Thanks.
>
> Danny

Committed revision 135733.

Thanks,
  Kai

-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

References:
- [patch i386]: PR/36280 option -fno-leading-underscore not treated
  - From: Kai Tietz
- Re: [patch i386]: PR/36280 option -fno-leading-underscore not treated
  - From: Danny Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]