Re: PATCH: Break up ix86_expand_vector_init_general

[Uros Bizjak <ubizjak at gmail dot com>]

H.J. Lu wrote:

> This patch is from AVX branch. It breaks up ix86_expand_vector_init_general
> into 3 functions so the they can be reused to support 256bit vectors. The
> current x86 backend have 256bit vector types, like V8SImode, V8SFmode, ...
> But there are no patterns to generate any instructions for them. The 256bit
> parts of those functions will only be called when AVX support is added to
> mainline. Since 256bit vector parts don't cause any regressions on
> Linux/Intel64, I didn't take them out. I can remove them if necessary. Also the code
>   

Please commit only non-AVX part. I think that introducing dead code that 
will support future patches is not appropriate, since we will lost track 
what is already committed. I would rather see future AVX patch packed 
together with its md patterns and supporting functionality.

> 2008-05-19  H.J. Lu  <hongjiu.lu@intel.com>
>
>         * config/i386/i386.c (ix86_expand_vector_init_concat): New.
>         (ix86_expand_vector_init_interleave): Likewise.
>         (ix86_expand_vector_init_general): Use them.  Assert word_mode
>         == SImode when n_words == 4.
>   


This is OK for mainline, but please without AVX support code.


Uros.