This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] Adjust output for strings in tree-pretty-print.c

From: Paolo Bonzini <bonzini at gnu dot org>
To: FX <fxcoudert at gmail dot com>
Cc: GCC Development <gcc at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 19 May 2008 16:44:45 +0200
Subject: Re: [RFC] Adjust output for strings in tree-pretty-print.c
References: <19c433eb0805190659g7442d645ga7755ec598856463@mail.gmail.com>

Notice the added final '\0' in the C case; I don't know if it's bad to
have it there, but I don't see a way to not output it and still have
the correct output for Fortran (whose strings are not NUL-terminated).

I think the best thing to do is to have a langhook then. I'm actually not sure that you want all those \0's in the Fortran front-end since the kind can be recovered from the {lb:1 sz:4} that is appended to the string. Endianness issues may also appear. Maybe you should call iconv in the langhook to get back to UTF-8, and print that representation instead.

Paolo

Follow-Ups:
- Re: [RFC] Adjust output for strings in tree-pretty-print.c
  - From: FX

References:
- [RFC] Adjust output for strings in tree-pretty-print.c
  - From: FX

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]