Re: [Fwd: [trunk] first patch to remove libcalls.]

[Kenneth Zadeck <zadeck at naturalbridge dot com>]

Ian Lance Taylor wrote:
> Kenneth Zadeck <zadeck@naturalbridge.com> writes:
>
>   
> > 2008-04-27  Kenneth Zadeck <zadeck@naturalbridge.com>
> >
> >   * doc/rtl.texi: Removed reference to REG_NO_CONFLICT notes.
> >   * optabs.c (expand_binop, expand_absneg_bit, expand_unop,
> >   expand_copysign_bit, ): Change call to emit_no_conflict_block to
> >   emit_insn and remove unneeded code to construct extra args.
> >   (emit_no_conflict_block): Removed.
> >   * optabls.h: (emit_no_conflict_block): Removed.
> >   * cse.c (cse_extended_basic_block): Remove search for
> >   REG_NO_CONFLICT note. * global.c: Removed incorrect comment added in
> > revision 117.
> >   * expr.c (convert_move): Change call to emit_no_conflict_block to
> >   emit_insn.
> >   * recog.c: Change comments so that they do not mention
> >   REG_NO_CONFLICT.
> >   * local_alloc.c (combine_regs): Removed last parameter.
> >   (no_conflict_p): Removed.
> >   (block_alloc): Removed note, no_conflict_combined_regno and set
> >   local vars. Removed all code to process REG_NO_CONFLICT blocks.
> >   (combine_regs): Removed already_dead and code to look for
> >   REG_NO_CONFLICT notes.
> >   * lower_subreg (remove_retval_note): Removed code to look for
> >   REG_NO_CONFLICT block.
> >   (resolve_reg_notes): Removed REG_NO_CONFLICT case.
> >   (resolve_clobber): Remove code to process libcalls that have
> >   REG_NO_CONFLICT notes.
> >   * loop_invariant.c (find_invariant_insn): Removed REG_NO_CONFLICT
> >   case.
> >   * combine.c (can_combine_p, distribute_notes):  Removed REG_NO_CONFLICT
> >   case.
> >   * config/cris/cris.md (movdi pattern): Changed
> >   emit_no_conflict_block to emit_insns.
> >   * config/mn10300/mn10300.md (absdf2, negdf2 patterns): Ditto.
> >   * config/m68k/m68k.md (negdf2, negxf2, absdf2, absxf2 patterns):
> >   Ditto.
> >   * reg-notes.def (NO_CONFLICT): Removed.
> >     
>
>
> I assume that the libcall_insn code in cse_extended_basic_block is
> going to be removed in your next patch.  If not, it should be
> simplified.
>
> This patch is OK.
>
> Thanks.
>
> Ian
>   
thanks,


sort of but not quite.   The plan is to first turn off the generation of 
libcall blocks.  Then we will follow this up with code to remove the 
handling of libcalls in all of  the passes.   The second libcall patch 
(already in your queue) is associated with removing generation of 
libcall blocks that come in from calls.c and its close friends. My guess 
is that there are most likely 2 more patches like that before we clean 
up the passes themselves.

kenny