This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/35657: Alignments of DFP types aren't consistent
On Tue, May 6, 2008 at 7:24 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Tue, May 6, 2008 at 3:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> > > We noticed another problem. We didn't align struct with _Decimal128 field
> > > properly when it is passed on stack. I am testing this patch now.
> > >
> >
> > This patch passed all the tests. OK for trunk and 4.3?
> >
> > Thanks.
> >
> > H.J.
> >
> >
> > >
> > > H.J.
> > > ---
> > > 2008-05-05 H.J. Lu <hongjiu.lu@intel.com>
> > >
> > > PR target/35657
> > > * config/i386/i386.c (contains_128bit_aligned_vector_p): Handle
> > > _Decimal128.
> > >
> > > (ix86_function_arg_boundary): Only align _Decimal128 to its
> > > natural boundary and handle it properly.
> > >
>
> Please rename the function to something other that ..._vector_p, since
> it now handles non-vector values. Perhaps
> contains_128bit_aligned_value_p?
I am planning to rename it for AVX since AVX register is 256bit. I'd like to
use something like contains_aligned_value_p. Will it be OK?
> OK for mainline and for 4.3 after a day or two without problems in mainline.
H.J.