This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,fortran] PR33268 read ('(f3.3)'), a rejected due to the extra (...)
- From: FX <fxcoudert at gmail dot com>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 2 May 2008 09:01:00 +0100
- Subject: Re: [patch,fortran] PR33268 read ('(f3.3)'), a rejected due to the extra (...)
- References: <48151421.1010706@verizon.net>
2008-04-27 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/33268
* gfortran.h: Add extra_comma pointer to gfc_dt structure.
* io.c (gfc_free_dt): Free extra_comma.
(gfc_resolve_dt): If an extra comma was encountered and io_unit is
type
BT_CHARACTER, resolve to format_expr and set default unit. Error if
io_kind is M_WRITE. (match_io): Match the extra comma and set new
pointer, extra_comma.
OK, with only one thing to change:
The io_kind is passed in extra_comma->value.logical. I used this
since it is an int and can hold the enumerator type without
problem. Another option would be to add "io_kind k" to the union
for value in gfc_expr, giving more readable code.
Yes, I think that'd be better. Please add a clear comment on top of
this new union member in gfortran.h.
Thanks,
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/