This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,rs6000] make -mno-spe work as expected
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 23 Apr 2008 17:07:20 -0400
- Subject: Re: [PATCH,rs6000] make -mno-spe work as expected
- References: <20080403200214.GU22202@codesourcery.com>
Nathan,
The intention and design of the patch are fine. My concern is
that your change to mspe (and future change to misel) place those
variables in the common target_flags mask for all rs6000 configurations.
target_flags is declared as an "int" and I believe that the Linux/SVR4
configuration currently uses mask bits up to bit 30 or 31; the embedded
configurations use fewer bits. If mspe does not push it over, misel will.
Unless I am mistaken about the bitmask usage or there is some
automagic way that the build machinery solves this, I think the bit usage
needs to be solved for this patch to be committed.
Other than that, I do not have (and never have had) any objection
to the patch.
Thanks, David