Re: [patch testsuite]: gcc.dg/builtins-13.c needs correction for C90 and target w64

[Kai Tietz <Kai dot Tietz at onevision dot com>]

"Joseph S. Myers" <joseph@codesourcery.com> wrote on 23.04.2008 15:33:16:

> On Wed, 23 Apr 2008, Kai Tietz wrote:
> 
> > Hi,
> > 
> > This patch corrects the declaration of size_t for target 
> > x86_64-pc-mingw32. The macro __SIZE_TYPE__ is for this target 'long 
long', 
> > so C90 will fail by a warning. To prevent this I used the mode(DI) 
> > attribute to declare size_t in this testcase.
> 
> This is not a diagnostic test.  Thus, the default "-ansi -pedantic" 
> options used by dg tests are inappropriate, and I suggest using 
dg-options 
> "-ansi" instead.
> 
> This applies to all tests using __SIZE_TYPE__ and not needing -pedantic; 

> __SIZE_TYPE__ is the correct thing to use for all targets and such 
> target-specific testcase changes should be avoided if possible.
> 
> If -pedantic is needed for a test, consider using
> 
> __extension__ typedef __SIZE_TYPE__ size_t;
> 
> to avoid anything target-specific.
I agree and will try to fix those kind of problems in your suggested way.
I changed the patches by setting dg-options "-ansi".
Are they ok for apply.

Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: gcc.de_builtins-13.txt~
Description: Binary data

Attachment: gcc.de_builtins-13.txt
Description: Text document