This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] ada: Allow 'Old attribute to be deeper in a subprogram

Samuel Tardieu wrote:
On 14/04, Robert Dewar wrote:

Arnaud Charlet wrote:

Regtested on i686-pc-linux-gnu.

Ok for trunk?

    gcc/ada/
	* sem_util.ads, sem_util.adb (In_Subprogram): New function.
	* sem_attr.adb (Analyze_Attribute, Attribute_Old case): Use it.

    gcc/testsuite/
	* gnat.dg/deep_old.adb: New.
This patch is OK, thanks.

Arno 
Looking at this more closely, I would not bother with the
abstraction In_Subprogram, it is perfectly clear to test

   if No (Current_Subprogram) then
      ...

Ok to commit this one on top? 

definitely OK to commit, sorry for confusion on this patch,
and thanks for noticing this clear error.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]