This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: cleanup for conversion exprs code patterns (1/16)
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Tomas Bily" <tomby at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, tbily at suse dot cz
- Date: Mon, 7 Apr 2008 14:48:44 +0100
- Subject: Re: [PATCH]: cleanup for conversion exprs code patterns (1/16)
- References: <20080331144912.C402CF00AB@atrey.karlin.mff.cuni.cz> <84fc9c000803310903p39fce391h5839bdfd762176c0@mail.gmail.com> <20080407130330.GA13557@atrey.karlin.mff.cuni.cz>
On Mon, Apr 7, 2008 at 2:03 PM, Tomas Bily <tomby@ucw.cz> wrote:
> Hi,
>
>
> >
> > NON_LVALUE_EXPRs should be removed without adding them
> > to such grouping scheme first. I suggest you patch tree-cfg.c:verify_expr
> > to handle it like
> >
> > NON_LVALUE_EXPR:
> > gcc_unreachable ();
> >
> > as they shouldn't survive until the middle-end IL (and thus handling for
> > it can be safely removed from all places once the verify_expr patch
> > bootstraps & tests cleanly). But please separate NON_LVALUE_EXPR
> > handling out into a separate patch(-series).
>
> I am not completely sure there. You mean remove only uses of
> NON_LVALUE_EXPRs where is not possibility to reach expr as
> NON_LVALUE_EXPR or completely remove NON_LVALUE_EXPRs thru whole gcc
> (mainly in frontends) ?
Only where it is not possible to reach expr as NON_LVALUE_EXPR
(which should be true for all places that are only ever called from points
after gimplification happened). Completely removing NON_LVALUE_EXPR
is for a followup task (though I don't mind the frontends retaining this
tree code).
Richard.