This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cleanup {push,pop}_function_context (also removing {enter,leave}_nested langhooks)


Paolo Bonzini wrote:
These two functions just call push_function_context_to and
pop_function_context_from, whose arguments are unused.  Therefore, this
patch just leaves the zero-argument variants and remove the one-argument
functions.

Also, the langhooks are used only by the C front-end.  After the
simplification that goes on in function.c, and given that the C
front-end only calls the function when it knows that cfun != 0, I think
it's better to provide wrappers for {push,pop}_function_context instead,
and call those from the front-end.

This is what the patch (bootstrapped/regtested i686-pc-linux-gnu) does.

Ok for mainline?

OK.


--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]