This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][TUPLES] Fix for builtin expander


2008/4/1 Diego Novillo <dnovillo@google.com>:

>  NFS over VPN?  Wow, you *are* patient.

I just mounted my home so that my Mac can see the patch file.


>  Mention what exactly needs fixing here.  It's not immediately
>  obvious.  This is to protect for CALL_EXPRs materialized during RTL
>  expansion, right?

Yes.

>  > @@ -11047,7 +10778,7 @@ validate_arg (const_tree arg, enum tree_
>  >     VOID_TYPE.  */
>  >
>  >  bool
>  > -validate_arglist (const_gimple call, ...)
>  > +validate_gimple_arglist (const_gimple call, ...)
>
>  Add a note in the comment stating that this is the GIMPLE
>  equivalent of validate_arglist, which operates on GENERIC.
>  Long term we will want to remove validate_arglist, but we cannot
>  do that until the RTL expander works from GIMPLE directly.

I understood the long term plan is to move to GIMPLE completely but
right now I just want to stabilize things there so that the compiler
works and tests pass.

-Doug

>  OK with those changes.
>
>
>  Diego.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]