This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- From: Jim Wilson <wilson at tuliptree dot org>
- To: George Helffrich <george at geology dot bristol dot ac dot uk>
- Cc: Jason Merrill <jason at redhat dot com>, FX Coudert <fxcoudert at gmail dot com>, John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 21 Mar 2008 19:54:52 -0700
- Subject: Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- References: <d0ea21574b9471bd56c45b5cd7bf624c@gly.bris.ac.uk>
George Helffrich wrote:
Modified from earlier submission based on comments received; sorry for
any repetition.
You added is_fortran() calls in response to Jason's review. However,
you added it to the dwarf2out.c patch but not the dbxout.c patch. I
would rather that they be consistent and that both made the is_fortran()
call. Also, I see that in the dbxout.c patch the DECL_THEAD_LOCAL_P
check was mysteriously commented out. It is still there in uncommented
form in the dwarf2out.c patch. Maybe a temporary change that you didn't
mean to include in the patch?
Otherwise this all looks good. If you fix dbxout.c to be consistent
with dwarf2out.c I'm OK with it, and won't insist on another review. Or
maybe make that change as a follow up patch, and check in this patch as
is (without the DECL_THREAD_LOCAL_P change), which would be OK too. I
don't want to cause too much trouble for a patch that was already
approved 4 years ago.
Jason might want to make his own comments, which probably won't happen
until Monday.
Jim