This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- From: George Helffrich <george at geology dot bristol dot ac dot uk>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches@@gcc.gnu.org <gcc-patches at gcc dot gnu dot org>, FX Coudert <fxcoudert at gmail dot com>, wilson at tuliptree dot org, John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Date: Fri, 21 Mar 2008 15:50:15 +0000
- Subject: Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- References: <f19307a1d4e4e3e4e876f50132030ee1@gly.bris.ac.uk> <47E29BA2.1030204@redhat.com>
On 20 Mar 2008, at 17:15, Jason Merrill wrote:
It looks like this patch can generate DW_TAG_common_block for
languages other than FORTRAN, which seems undesirable. Specifically,
it seems that any use of DECL_VALUE_EXPR could trigger this code, such
as anonymous unions in C++. I notice that you even have C++-specific
code in common_check.
Jason
Thanks for spotting that; easily guarded against with an !if_fortran()
test at the start of common_check. With that, the C++-specific code
can be eliminated, too.
--
George Helffrich