This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions


Hello!

> This is a proposed patch for bug 35504. The testcase is in bugzilla.

Huh, the attachment is scrambled. See [1].

Please add the testcase to the patch. Also, send a ChangeLog entry for
gcc/ChangeLog and gcc/patches/ChangeLog, separate from the patch. It
would be nice, if you describe the rationale for the thange together
with the patch submission (Your comment #0 from PR will do). Please
read http://gcc.gnu.org/contribute.html (Submitting Patches section in
particular) for further instructions.

You didn't say how you test the patch. At least you should bootstrap
gcc with your patch and run the testsuite for defult languages. I can
help you with this step if you are unable to do it.

[1] http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00610.html

Thanks for your contribution,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]