Re: [PATCH fixincludes] AIX stdio inclhack - fixes PR20366

["Peter O'Gorman" <gcc-patches at mlists dot thewrittenword dot com>]

Hi Bruce,

Thank you for the quick response.

On Mon, Mar 03, 2008 at 01:38:43PM -0800, Bruce Korb wrote:
> Hello Peter,
> 
> On Mon, Mar 3, 2008 at 12:33 PM, Peter O'Gorman
> <gcc-patches@mlists.thewrittenword.com> wrote:
> >  This patch uses the fixincludes machinery to modify stdio.h so that,
> >  if __GNUG__, _LARGE_FILES, and __cplusplus are defined it undefs the
> >  fopen etc and uses __asm__ to alias the symbols instead.
> 
> Instead of duplicating "stdio.h" with a trailer added, you might consider
> a "replacement" fix that does an "include_next", unless there are
> other fixes required as well.  In that case, the "wrap" would be required.

The stdio_stdarg_h hack is also used. I guess we could rework this
patch to use include_next and incorporate both fixes if that is
desired.

> 
> >  Note that although the generated fixincl.x is included in this patch,
> >  the committer may want/need to use a later version of autogen to get
> >  the gplv3 version.
> 
> Doesn't Albert have a port of autogen to your various platforms?

I don't believe that it is currently at the latest version, and do not
know if there is a version requirement for autogen generated files in
gcc. It's not important anyway, as you say.

> In any event, the generated file diffs aren't needed for a patch posting.
> 
> >  We do not have write access to the gcc repository, so would be
> >  grateful if someone could apply this for us if approved.
> 
> I'd like the AIX maintainer to say, "works for me" first.  Thanks.

Yes, we would prefer that also. 

Thanks,
Peter