Re: Reject dllimport on scalar typedefs (bug 33963)

["Danny Smith" <dansmister at gmail dot com>]

On Thu, Feb 28, 2008 at 4:37 PM, Mark Mitchell <mark@codesourcery.com> wrote:
> Joseph S. Myers wrote:
>
>  > So is this patch OK or not?  As far as I can tell it fixes the testsuite
>  > regression - but there may be other cases that have also regressed, not
>  > covered by the testsuite, that would best have separate bugs filed and
>  > marked as regressions.
>
>  Yes, this patch is OK.  I think we all agree the behavior is a step
>  forward.  If Danny thinks that we shouldn't accept these attributes on
>  any types, even class types, then that's a further restriction, easily
>  implemented on top of your patch.

Yes OK.
The lack of warning on things like

struct /* __attribute__((dllimport))*/ _foo {
  static int i;
};
typedef _foo Foo __attribute__((dllimport));  // dllimport attribute ignored

is not a regression.

Thanks for fixing this Joseph.

Danny