This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH fortran] Use fold_build everywhere
Attached is an updated version of the patch which also modifies the
copyright years of the touched files and which fixes a typo I made
when I tried to fix formatting in the diff.
My understanding was that the copyright years in the files need to
include year X iff a release of the codebase is done in year X,
independently of whether the file was actually modified or not. From
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html:
To update the list of year numbers, add each year in which you have
made nontrivial changes to the package. (Here we assume you're
using a publicly accessible revision control server, so that every
revision installed is also immediately and automatically
published.) When you add the new year, it is not required to keep
track which files have seen significant changes in the new year and
which have not. It is recommended and simpler to add the new year
to all files in the package, and be done with it for the rest of
the year.
Other than that, the patch is OK. To satisfy my curiosity: I
sometimes used buildN() instead of fold_buildN() when I know that the
expression can't be simplified, to avoid extra burden on the middle-
end, was that wrong or is it just that the benefit is too small to
notice?
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/