This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch Submission Policy [Doc Patch]


On Sun, 24 Feb 2008, Tom Browder wrote:
> OK, here is my revised patch and ChangeLog.  I added a small change to
> clarify what languages are required for patch testing (see msg
> <http://gcc.gnu.org/ml/gcc/2008-02/msg00495.html>).
> 
> I made the change to patch generation to delete the '3' from '-c3p'
> and eliminated all my other previous changes.

These two hanks are fine, thanks!  I went ahead and committed both.

> I added a short blurb for CVS diff.

This is not correct as far as I can see (and just verified on an
older Solaris system).  The use of GNU diff is not neccessary, CVS
itself already is able to handle this.  Given that we barely use
CVS any more (only for the web pages) my recommendation is to not
add more details than we currently have.

Gerald


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]