This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] [tuples] some aux functions
On Fri, Feb 22, 2008 at 1:24 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Fri, Feb 22, 2008 at 2:27 AM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>
> > We certainly should not. But just testing for boolean_true|false_node
> > is not enough, instead integer_zerop / integer_onep is the correct
> > condition.
>
> Good point. In this case, all uses must be updated because it is no
> longer possible to have conditionals of the form 'if (constant)'
> anymore.
How are they represented now?
> Regarding the names, sure. If gimple_cond_constant_true_p is easier,
> let's rename them.
>
> Rafael, another thing that I just noticed, one of these two predicates
> can just be implemented by calling the other one with '!'.
Are you sure? What if it is not a constant predicate? That is, I see
we test for a tristate - true, false and unknown. Or not?
Richard.