This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch RFA] Fix PR rtl-optimization/35190
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: stevenb dot gcc at gmail dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 16 Feb 2008 09:06:51 +0900 (JST)
- Subject: Re: [patch RFA] Fix PR rtl-optimization/35190
- References: <571f6b510802151407r16664a7br7bfbeecdb40ddf0f@mail.gmail.com>
"Steven Bosscher" <stevenb.gcc@gmail.com> wrote:
> This seems like just a way to paper over the problem.
>
> If local-alloc makes a substitution that results in a bad insn, then
> the validation of the substitution should fail. The SH target specific
> code should just not accept this. Or, you could test for
> HAS_LONG_UNCOND_BRANCH like bb-reorder.c does. There is nothing I see
> in this bug report that is limited to hot/cold splitting, you can
> probably trigger this bug with a carefully crafted test case. Finally,
> it's not clear (at least to me) whether there are other substitutions
> that your patch would disable.
Ok, I withdraw this patch and will prepare a SH back end patch.
Thanks for your suggestion.
Regards,
kaz