This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Change order of tentative parsing in cp_parser_postfix_dot_deref_expression (PR c++/35138)
On 13/02/2008, Mark Mitchell <mark@codesourcery.com> wrote:
>
> So, at first glance, it seems like your idea doesn't work: the
> template-id expansion is going to have an arbitrarily long sequence of
> tokens. But, since we want a pseudo-destructor, we're not interested in
> the class-name expansion.
Then, why are we calling c_parser_type_name at all? Wouldn't it be
better to have a function called c_parser_nonclass_type_name. That
would be clearer and faster.
> So, I think your patch is OK, but I think you should expand on the
> comment. Something like:
Jakub, since you have been looking at this more than me. What do you
think about my patch? Can you think of a case where it may break?
Cheers,
Manuel.