Re: Fix PR 33738

[Diego Novillo <dnovillo at google dot com>]

On 2/13/08 11:01 AM, Ian Lance Taylor wrote:

> If you're testing warn_type_limits above, then shouldn't you use
> OPT_Wtype_limits below?  Only that seems strange, because
> -Wtype-limits is C/C++ specific.  We shouldn't introduce a new -Wextra
> warning, because we are trying to name all those warnings.

Thanks.  I've fixed this one in my local tree.

> Perhaps the best solution is to move Wtype-limits from c.opt to
> common.opt, and move the handling of it from c-opts.c to opts.c.  The
> documentation does not say that it is C/C++ only, so this seems OK to
> me.

I agree.  Making it a common warning seems like the best option.


Diego.