This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C/C++/ObjC/ObjC++ PATCH] Battle of the comptypes (PR c++/35049)
On Sun, 10 Feb 2008, Mark Mitchell wrote:
> Paolo Bonzini wrote:
>
> > Bootstrapped/regtested i686-pc-linux-gnu, C/C++/ObjC/ObjC++/Fortran/Java.
> > Ok for mainline together with reverting Doug's changes?
>
> Like Doug, I think this is the right idea.
>
> I also agree with Joseph that we need to make the names for these functions
> map onto the concepts used in the language standards -- but perhaps we can do
> that later? So, I suggest that we just change the C front-end version of
> comptypes to add the extra parameter (as in your patch) but leave out the
> same_type_p and same_type_ignoring_top_level_qualifiers_p changes.
>
> Joseph, what do you think of that?
My suggestion is not to change names or signatures of front-end-internal
functions such as comptypes, but to add a new function with a different
name that does what's required by the common code (it only appears to be
one call to comptypes in c-common.c) and define it in each front end as a
wrapper to the front-end-internal function. Then we can deal separately
with such things as the naming of functions within the front ends and
stopping common code from using c-tree.h.
--
Joseph S. Myers
joseph@codesourcery.com