This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, spu] Implementation of vector unpack for Cell SPU
- From: Trevor_Smigiel at playstation dot sony dot com
- To: Ira Rosen <IRAR at il dot ibm dot com>
- Cc: andrew_pinski at playstation dot sony dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 6 Feb 2008 12:25:12 -0800
- Subject: Re: [patch, spu] Implementation of vector unpack for Cell SPU
- References: <20080123050018.GA5660@playstation.sony.com> <OF7D6DAED3.D8FB4FAE-ONC22573E7.0025E398-C22573E7.00272B1C@il.ibm.com>
Ira,
> I changed the patch according to your comments. I removed vec_extendhisi2
> and used spu_xshw instead. I also used vec_select in vec_unpacks, since
> otherwise I got "warning: this decimal constant is unsigned only in ISO
> C90".
Cool, the vec_select looks much nicer. In the *_v16qi patterns you put
vec_select:V8HI, which should be vec_select:V8QI.
>
> Tested on Cell SPU. O.K. for 4.4?
Looks good. After the minor change above, go ahead.
Trevor