This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PR c++/33887] Fix incorrect use of jboolean in link.cc

From: Tom Tromey <tromey at redhat dot com>
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: "Alexandre Oliva" <aoliva at redhat dot com>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
Date: Fri, 18 Jan 2008 14:13:13 -0700
Subject: Re: [PR c++/33887] Fix incorrect use of jboolean in link.cc
References: <ork5m7t0g3.fsf@oliva.athome.lsd.ic.unicamp.br> <84fc9c000801181219h2f1cd13nf436f11f0d04e135@mail.gmail.com> <84fc9c000801181225y68d6ef86lb047591664f5b46a@mail.gmail.com>
Reply-to: tromey at redhat dot com

>>>>> "Richard" == Richard Guenther <richard.guenther@gmail.com> writes:

Richard> Thinking about it -- jboolean is unsigned : 1?  I guess for b
Richard> += x to work it should be bool : 1, which has special
Richard> semantics for addition.  That is:

I think it should really just work the same as 'bool'.
So, yeah, I think your patch is probably what we want.

Alexandre's patch is still what I prefer, though, since I don't like
to see math-y operations on booleans.

Tom

References:
- [PR c++/33887] Fix incorrect use of jboolean in link.cc
  - From: Alexandre Oliva
- Re: [PR c++/33887] Fix incorrect use of jboolean in link.cc
  - From: Richard Guenther
- Re: [PR c++/33887] Fix incorrect use of jboolean in link.cc
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]