This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [boehm-gc] Define HBLKSIZE to 4096 for MIPS
- From: Andrew Haley <aph at redhat dot com>
- To: "rsandifo at nildram dot co dot uk" <rsandifo at nildram dot co dot uk>
- Cc: David Daney <ddaney at avtrex dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "hboehm at gcc dot gnu dot org" <hboehm at gcc dot gnu dot org>, Hans Boehm <Hans dot Boehm at hp dot com>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Mon, 14 Jan 2008 19:03:08 +0000
- Subject: Re: [boehm-gc] Define HBLKSIZE to 4096 for MIPS
- References: <87sl1dyi8i.fsf@firetop.home> <477E6F39.3070502@avtrex.com> <alpine.DEB.0.99999.0801072147460.3807@quinault.hpl.hp.com>
Hans Boehm writes:
> It also looks like a good idea to me. The collector assumes that
> the page size is a multipe of HBLKSIZE, so we should probably
> change this on some other platforms with configurable page sizes
> as well.
>
> I missed the first part of this discussion, and can't immediately find
> it. Did this result in failures outside the collector test itself?
> I would have expected this to affect only incremental GC, which
> I thought was still hard to use with gcj?
>
> Hans
>
> On Fri, 4 Jan 2008, David Daney wrote:
>
> > Richard Sandiford wrote:
> >> 4096 is the default (and smallest) page size for both 32-bit and 64-bit
> >> MIPS Linux, so I'd like to use it as the default HBLKSIZE for both.
> >> The definition in patch below overrides the target-independent LP64
> >> default of 8k and copies similar definitions for other 64-bit Linux
> >> targets.
> >>
> >
> > Thanks. I thought it might be something like this.
> >
> >
> >> Tested on mips64-linux-gnu, where it fixes all remaining n64 libjava
> >> failures on QEMU. (The o32 and n32 results are clean before and after
> >> the patch.) OK to install?
As it's approved by Hans, this is fine.
Andrew.
--
Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, UK
Registered in England and Wales No. 3798903