Re: [PATCH] Separate ignored return type qualifier warning.

["=?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=" <dougkwan at google dot com>]

I am going to check this into main line.  This patch include
suggestions from Manuel. I bootstrapped on i686-uknown-linux-gnu and
ran the regression tests.

-Doug

11 Jan 2008 17:31:36 -0800, Ian Lance Taylor <iant@google.com>:
> "Manuel López-Ibáñez" <lopezibanez@gmail.com> writes:
>
> > On 10 Jan 2008 10:49:38 -0800, Ian Lance Taylor <iant@google.com> wrote:
> > > Diego Novillo <dnovillo@google.com> writes:
> > >
> > > In short, I think it was a mistake to put this new warning under
> > > -Wreturn-type.  Since this warning is new for gcc 4.3, I think it is
> > > entirely appropriate to move it now, before gcc 4.3 is released.
> > >
> > > Does anybody feel otherwise?
> >
> > From that point of view, I agree. Moreover, given your explanation, I
> > would move the warning from Wall to Wextra.
> >
> > Also, I would name it -Wignored-qualifiers. It is shorter and perhaps
> > in the future we would like to extend it for other cases.
> >
> > If the patch gest accepted, please, also submit a short entry that
> > adds this option to http://gcc.gnu.org/gcc-4.3/changes.html. For
> > example:
> >
> > * New command-line options -Wtype-limits, -Wold-style-declaration,
> > -Wmissing-parameter-type, -Wempty-body, -Wclobbered and
> > -Wignored-qualifiers have been added for finer control of the diverse
> > warnings enabled by -Wextra.
>
> I like both of those suggestions.  Doug, I'll approve your patch for
> mainline with Manuel's changes.
>
> Thanks.
>
> Ian
>

Attachment: patch.txt
Description: Text document