This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, janis187 at us dot ibm dot com, dnovillo at google dot com
- Date: Thu, 10 Jan 2008 21:28:27 -0800
- Subject: Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
- References: <Pine.GSO.4.58.0801110020440.2714@caipclassic.rutgers.edu>
On Jan 10, 2008 9:24 PM, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> Hi Diego,
>
> I believe you wrote this testcase, which is failing with -fpic/-fPIC on
> i686 and x86_64 on all branches. E.g.:
> http://gcc.gnu.org/ml/gcc-testresults/2008-01/msg00383.html
>
> Patch below allows the it to pass, but I wanted to be sure it doesn't
> change the nature of the testcase.
This testcase is only passing because baz is being inlined which seems
wrong, baz should be marked as noinline and then should be fixed by a
fix to the tree level optimization.
Thanks,
Andrew Pinski