This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA:] more glibc fixinclude adjustments for extern inline
On Jan 3, 2008 5:10 PM, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:
> > Date: Wed, 2 Jan 2008 16:37:30 +0100
> > From: Hans-Peter Nilsson <hp@axis.com>
>
> > > Date: Wed, 2 Jan 2008 11:28:55 +0100
> > > From: "Richard Guenther" <richard.guenther@gmail.com>
> >
> > > This patch seems to break coreutils build with glibc 2.6:
>
> I can't repeat this. While "my" wchar.h is fixinced just fine,
> yours in the attachment isn't edited at all with 131302. That's
> just as expected; it doesn't match the select "(^| )extern
> __inline" argument of glibc_c99_inline_5.
>
> Is your tree pristine or what does svn diff fixincludes say?
> (Perhaps I misunderstood; did you by "this patch" refer to the
> commit or perhaps the suggested changes?)
This is plain trunk without patches on x86_64-linux. I refered to
the commit
2007-12-18 Hans-Peter Nilsson <hp@axis.com>
* inclhack.def: (glibc_c99_inline_1a, glibc_c99_inline_5): New.
* fixincl.x: Regenerate.
* tests/base/wchar.h: Update.
* tests/base/features.h: New.
it worked ok with r131004 and I saw the breakage first with r131032.
Richard.
> > > original wchar.h and fixed wchar.h attached.
> >
> > I see.
>
> Actually, mostly I didn't. (Reading fixfixes.c:format_fix it
> appears that in absence of a second c_fix_arg, the "select"
> argument is used, as I originally thought.)
>
> brgds, H-P
> PS: I wish...the fixincluded file contained the md5 of inclhack.def!
>