This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c


"Joseph S. Myers" wrote on 20.12.2007 14:56:42:

> On Thu, 20 Dec 2007, Kai Tietz wrote:
> 
> > I moved the test case to gcc.dg/format as mentioned. No until now I 
didn't 
> > ran all test-case for this. But I am certain, we need to re-arrange 
things 
> > here.
> 
> I will await a patch with such rearrangements, confirmed to pass all 
tests 
> on both MinGW and non-MinGW, and with new tests added to test that all 
the 
> standard and GNU features not supported by Windows receive proper 
> diagnostics (for example, a test that %ll gets a diagnostic on Windows), 

> before attempting any detailed review.

Fine. I am working on that, but may it will take till January (reasoned by 
vacation).

> I also await the answer to my question:
> 
> Does the set of format features supported on Windows depend at all on 
the 
> version of Windows?  If so, for what version of Windows did you prepare 
> the tables of supported features?

It does not depend on the version of Windows, but on the version of the MS 
runtime. E.g. the standard runtime 'msvcrt.dll' does not support the 'll' 
proper, but the the 'msvcr80.dll' (the new runtime of MS which is not part 
of the OS itself) supports it. Reasoned by the fact, that mingw just 
supports the 'msvcrt.dll' variant (it is part of the OS), I think gcc 
should just support this one.

> Were the tables prepared by examining Windows documentation, or by 
running 
> tests on Windows?  Either would be OK, but one or the other must have 
been 
> done for every feature and combination in the tables you have of Windows 

> formats, and for verifying that the C99 features removed as not 
supported 
> on Windows are indeed not supported.

I took the information about the tables out of the msdn library 
documentation and tested it by doing a canadian cross on gcc for the 
64-bit mingw. I agree, that there should be a test case probing the 
supported and non-supported formatting rules (as e.g. C99).

Cheers,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer: 
Ulrike DÃhler, Manuela Kluger



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]