This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][4.4] Conversion of tree.h STRIP_* macros into static inline functions


>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:

>> Also I noticed you have some coding style violations:
>> +   return CONST_CAST_TREE(exp);
>> there is missing a space there.

Simon> I did a quick scan of gcc source -- it turns out there are more uses
Simon> of CONST_CAST_TREE (excluding mine) present with this violation, than
Simon> without.

Yeah, this stuff sneaks in occasionally.  I think the usual rule is
not to let in new erroneous uses.

IMO we should pick a set of GNU indent flags and declare that to be
our official coding style.  Then developers can run indent before
patch submission and be confident in the results.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]