This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][4.4] Conversion of tree.h STRIP_* macros into static inline functions


>>>>> "Andrew" == Andrew Pinski <pinskia@gmail.com> writes:

Andrew> Really you should not be changing the behavior of
Andrew> STRIP_NOPS/STRIP_SIGN_NOPS, etc. There is a simple way around to
Andrew> changing their behavior, still have a macro but pass address to the
Andrew> new inline function and act on that.  Or even have them take an
Andrew> address to a tree.

I think the functional style is better, when possible, because it is
simpler to reason about, and can be used more freely.  Unless there is
a strong reason, I'd prefer that we use ordinary functions in
situations like this.

Andrew> And this just looks like some child started to draw all over the wall
Andrew> (that reminds me, I need to deal with a couple of children soon):

Please be polite.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]