This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] fix gcc.dg/torture/builtin-modf-1.c
- From: Jack Howarth <howarth at bromo dot msbb dot uc dot edu>
- To: Janis Johnson <janis187 at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 18 Dec 2007 22:00:17 -0500
- Subject: Re: [testsuite] fix gcc.dg/torture/builtin-modf-1.c
- References: <1197941340.7115.7.camel@janis-laptop>
Janis,
On powerpc-apple-darwin9, I still get a compile failure when
I link with or without -funsafe-math-optimizations...
[jack-howarths-power-mac-g5:~] howarth% /sw/src/fink.build/gcc43-4.2.999-20071216/darwin_objdir/gcc/xgcc -B/sw/src/fink.build/gcc43-4.2.999-20071216/darwin_objdir/gcc/ /sw/src/fink.build/gcc43-4.2.999-20071216/gcc-4.3-20071216/gcc/testsuite/gcc.dg/torture/builtin-modf-1.c -O1 -fno-show-column -lm -m32 -o builtin-modf-1.exe
Undefined symbols:
"_link_error", referenced from:
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
_foo in cccVrzuV.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
Any idea why we might be seeing this on darwin?
Jack
On Mon, Dec 17, 2007 at 05:29:00PM -0800, Janis Johnson wrote:
> The test modified by this patch started failing on powerpc*-linux,
> powerpc-*-darwin*, and powerpc-*-aix* when -funsafe-math-optimizations
> began to imply -fno-signed-zeros. The test fails with earlier versions
> of GCC when -fno-signed-zeros is used explicitly. Furthermore, the
> option -funsafe-math-optimizations wasn't really needed on
> powerpc*-linux.
>
> This patch removes the dg-options directive for
> -funsafe-math-optimiztions, which should make the test pass again for
> powerpc targets. If it turns out to still be needed for mips-*-irix6
> it can be added back for that target. I plan to check this in
> tomorrow if there are no objections.
>
> Tested on powerpc64-linux with -m32/-m64.
>
> 2007-12-18 Janis Johnson <janis187@us.ibm.com>
>
> * gcc.dg/torture/builtin-modf-1.c: Remove -funsafe-math-optimizations.
>
> Index: gcc/testsuite/gcc.dg/torture/builtin-modf-1.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/torture/builtin-modf-1.c (revision 131004)
> +++ gcc/testsuite/gcc.dg/torture/builtin-modf-1.c (working copy)
> @@ -7,9 +7,6 @@
>
> /* { dg-do link } */
> /* { dg-options "-fno-finite-math-only" { target sh*-*-* } } */
> -/* In order to fold algebraic exprs below, targets with "composite"
> - floating point formats need -funsafe-math-optimizations. */
> -/* { dg-options "-funsafe-math-optimizations" { target mips*-*-irix6*
> powerpc*-*-* } } */
>
> extern void link_error(int);
>
>