This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][modulo-sched] Fix generation of reg-moves (was: Fix generation of prolog and epilog)


Revital1 Eres/Haifa/IBM wrote on 18/12/2007 13:49:14:

> Hello,
>
> Following our off-line discussion regarding the implementation of this
> patch; I re-submit it with the following change: the reg-moves of the
> kernel are inserted right before the notes which precede the insn they
> relates to.  This will also prevent the problematic case were redundant
> reg-moves are generated while creating the prolog/epilog as reported
> previously.
>
> I am now re-testing the patch on powerpc64-linux, x86_64-linux and SPU.
> OK for mainline once testing completes?
>

Yes, this wrong-code fix is ok.
In general it's better to keep dump info additions separate from the actual
bug fixing line(s).
Ayal.

> Thanks,
> Revital
>
> 2007-12-17  Alexander Monakov  <amonakov@ispras.ru>
>             Revital Eres  <eres@il.ibm.com>
>
>         * modulo-sched.c (generate_reg_moves): Insert the reg-moves
>         right before the notes which precedes the insn, if they exists.
>         (loop_canon_p): Add dump info.
>         (sms_schedule): Likewise.
>
> testsuite:
>
>         * gcc.dg/sms-5.c: New testcase.

>
> [attachment "sms-5.c.txt" deleted by Ayal Zaks/Haifa/IBM] [attachment
> "patch_fix_regmoves_17.txt" deleted by Ayal Zaks/Haifa/IBM]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]