This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] PR34495 - accepts invalid init-expr with TRANSFER
- From: Daniel Franke <franke dot daniel at gmail dot com>
- To: fortran at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 18 Dec 2007 11:46:49 +0100
- Subject: Re: [patch, fortran] PR34495 - accepts invalid init-expr with TRANSFER
- References: <200712181139.15621.franke.daniel@gmail.com>
On Tuesday 18 December 2007 11:39:14 Daniel Franke wrote:
> 2007-12-18 Daniel Franke <franke.daniel@gmail.com>
>
> PR fortran/34495
> * transfer_simplify_2.f90: Fixed invalid initialization expressions.
> * transfer_simplify_7.f90: New test.
Patch again, this time including the new testcase ...
Index: simplify.c
===================================================================
--- simplify.c (revision 131020)
+++ simplify.c (working copy)
@@ -4088,6 +4088,7 @@ gfc_simplify_transfer (gfc_expr *source,
unsigned char *buffer;
if (!gfc_is_constant_expr (source)
+ || (gfc_init_expr && !gfc_is_constant_expr (mold))
|| !gfc_is_constant_expr (size))
return NULL;
Index: expr.c
===================================================================
--- expr.c (revision 131020)
+++ expr.c (working copy)
@@ -2200,7 +2200,11 @@ check_init_expr (gfc_expr *e)
if (gfc_check_iter_variable (e) == SUCCESS)
break;
- if (e->symtree->n.sym->attr.flavor == FL_PARAMETER)
+ /* A PARAMETER shall not be used to define itself, i.e.
+ REAL, PARAMETER :: x = transfer(0, x)
+ is invalid. */
+ if (e->symtree->n.sym->attr.flavor == FL_PARAMETER
+ && e->symtree->n.sym->value)
{
t = simplify_parameter_variable (e, 0);
break;
Index: ../testsuite/gfortran.dg/transfer_simplify_2.f90
===================================================================
--- ../testsuite/gfortran.dg/transfer_simplify_2.f90 (revision 131020)
+++ ../testsuite/gfortran.dg/transfer_simplify_2.f90 (working copy)
@@ -71,7 +71,7 @@ contains
subroutine integer8_to_real4
integer :: k
- integer(8), parameter :: i1(2) = transfer ((/asin (1.0_8), log (1.0_8)/), i1)
+ integer(8), parameter :: i1(2) = transfer ((/asin (1.0_8), log (1.0_8)/), 0_8)
integer(8) :: i2(2) = i1
real(4), parameter :: r1(4) = transfer (i1, (/(1.0_4,k=1,4)/))
real(4) :: r2(4)
@@ -82,7 +82,7 @@ contains
subroutine integer8_to_complex4
integer :: k
- integer(8), parameter :: i1(2) = transfer ((/asin (1.0_8), log (1.0_8)/), i1)
+ integer(8), parameter :: i1(2) = transfer ((/asin (1.0_8), log (1.0_8)/), 0_8)
integer(8) :: i2(2) = i1
complex(4), parameter :: z1(2) = transfer (i1, (/((1.0_4,2.0_4),k=1,2)/))
complex(4) :: z2(2)
Index: ../testsuite/gfortran.dg/transfer_simplify_7.f90
===================================================================
--- ../testsuite/gfortran.dg/transfer_simplify_7.f90 (revision 0)
+++ ../testsuite/gfortran.dg/transfer_simplify_7.f90 (revision 0)
@@ -0,0 +1,18 @@
+! { dg-do compile }
+! PR fortran/34495 - accepts invalid init-expr with TRANSFER
+
+
+! 'b' is implicitly typed
+real :: a = transfer(1234, b) ! { dg-error "does not reduce to a constant" }
+
+! 'y' is used on lhs and rhs
+real :: y = transfer(1234, y) ! { dg-error "does not reduce to a constant" }
+
+
+! 'bp' is implicitly typed
+real, parameter :: ap = transfer(1234, bp) ! { dg-error "does not reduce to a constant" }
+
+! 'yp' is used on lhs and rhs
+real, parameter :: yp = transfer(1234, yp) ! { dg-error "does not reduce to a constant" }
+
+end