This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR32901: handle assignment...(and PR34465 and PR34448)


> It looks good to me (though you need to find someone^H^H^H^H^H^H^HDiego to
> approve it anyway), except that the unshare_expr is IMHO done too early,
> wasting GC memory if gimplify_init_constructor returns GS_ERROR.  I believe

Good catch!  Fixed.

Diego, how does the patch look?

Aldy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]