Re: [RFC][4.4] Conversion of tree.h STRIP_* macros into static inline functions

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:

Tom> Also, in this particular case, in my opinion, it would be better to
Tom> lowercase the function names.  This would have the nice effect of
Tom> breaking bad code that resulted from a merge.

Simon> When the general issue of lowercasing converted and inlined macros
Simon> came up a couple of months ago, the overall consensus was to leave
Simon> them uppercased, because of disinclination to edit all call sites.

Yeah, I remember that.  Actually, I agreed with it then.  But after
seeing the patch, and given that you had to edit all the users anyway,
I changed my mind for this particular case.

But...

Simon> For the moment, however, I'm inclined to leave them alone.

No problem.  This particular change is simple to do as a followup
patch with a perl script, anyway, should we want it.

Simon> The second, more prosaic, is that if STRIP_*() are documented
Simon> anywhere, it'll be their uppercased versions that are
Simon> documented; I'd prefer not to break any such documentation.  Or
Simon> more accurately, I'd prefer not to have to find and update the
Simon> documentation!

FWIW it is extremely unlikely that these are documented anywhere
outside the source.  There are some tree docs in gcc/doc, but I didn't
see a mention of these macros there.  And, anything outside the tree
is destined to rot anyhow.

Simon> Retesting now... guess I'll be mailing a revised version of the patch
Simon> on test completion.

Thanks.

Tom