This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ada: Use explicit conversion to VString_Ptr


Samuel Tardieu wrote:
On 13/12, Arnaud Charlet wrote:

| > Replace .all'Unchecked_Access by an explicit conversion to VString_Ptr,
| > as is done in BreakX already.
| > | > gcc/ada/
| > * g-spipat.adb (Break): Use explicit conversion to VString_Ptr.
| | No, this change is wrong. We just did exactly the opposite of that for good
| reasons, see the message I just sent on gcc-patches
| ([Ada] Fix accessibility error in GNAT.Spitbol.Patterns), and
| see svn log/svn annotate.


Ok, it got caught by the -gnatw.u warning; if Unchecked_Access is indeed
mandatory here, the -gnatw.u patch may be missing a corner case.

This makes me worry about that patch. I really think we should redo this using my approach, which is for sure reliable.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]