This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR34324 - Module files on CRLF systems


On Thursday 13 December 2007 21:39:40 Tobias Burnus wrote:
> > Up to now, the module parser does not like '\r' characters in the input
> > stream and aborts at such. The fix is to ignore these characters, as done
> > in scanner.c (load_line).
>
> I wonder why this error did not show up before.

It seems that user interaction is needed. Either by 'unix2dos' or opening the 
file in an editor that replaces LF by CRLF by default and blindly 
answering 'yes' upon request to overwrite. Thus, the patch is not strictly 
necessary as Steven points out in the PR, module files state: "If you edit 
this, you'll get what you deserve" -- adding '\r' counts as changing the 
file. However, the patch is non-intrusive, so there shouldn't be to much room 
for regressions.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]