This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR middle-end/33088


> I think the idea and implementation are sound.  But, did you verify
> that the places
> we set DECL_GIMPLE_REG_P in the gimplifier are properly guarded with the
> changed predicate?  That is, shouldn't the occurances of
>
>       if ((TREE_CODE (TREE_TYPE (parm)) == COMPLEX_TYPE
>
>            || TREE_CODE (TREE_TYPE (parm)) == VECTOR_TYPE)
>
> ...
>         DECL_GIMPLE_REG_P (parm) = 1;
>
> changed to use the is_gimple_reg_type predicate?  (at least in the
> gimplifier)

It seems to me that I already answered to this question in the message. :-)

The rationale is that the flag is only really read through is_gimple_reg.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]