This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR rtl-optimization/27971


On Dec 6, 2007 10:48 AM, Richard Guenther <richard.guenther@gmail.com> wrote:
>
> On Dec 6, 2007 9:00 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
> > Raksit Ashok wrote:
> > > Please see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27971
> > >
> > > Modified find_split_point in combine.c to catch an rtx of the form:
> > >
> > > (mem/s:SI (plus:SI (and:SI (reg/v:SI 59 [ x ])
> > >                (const_int 12 [0xc]))
> > >            (symbol_ref:SI ("array") <var_decl 0xf7ef20b0 array>)) [3
> > > array S4 A32])
> > >
> > > and introduce a split at the first operand of the PLUS expr.
> >
> > I cannot approve it, but it seems ok apart from the lack of a testcase.
>
> Please add a testcase, then this is ok for 4.4 (it doesn't seem to be
> a regression fix).

I stand corrected that we are not in regression-only fixes mode yet, so
the patch is ok with a testcase.

Thanks,
Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]